Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specify required property on DesignTypeParameterAttribute #169

Open
unaizorrilla opened this issue Sep 18, 2020 · 0 comments
Open
Assignees
Labels
Core help wanted Extra attention is needed UI
Milestone

Comments

@unaizorrilla
Copy link
Collaborator

At this moment, the metadata for all toggle properties does not allow to specify "Is Required or Is Optional" and this is very usefull for Esquio UI. Currently, on the UI, the user can set null values on toggle properties ( string or numeric properties ) and this missconfiguration could be confusing for the user on Esquio UI and also reduce the performance on toggle evaluation (due throw exceptions)

The steeps to solve this kind of issues could be

  • Allow a new property on DesignTypeParameterAttribute to specify if the property is required or not
  • Modify the Esquio UI to add "null" validation to required properties
  • Modify all toggles to be more defensive on null parameter properties
@unaizorrilla unaizorrilla added help wanted Extra attention is needed UI Core labels Sep 18, 2020
@unaizorrilla unaizorrilla added this to the Esquio-5 milestone Sep 18, 2020
@unaizorrilla unaizorrilla self-assigned this Sep 18, 2020
@unaizorrilla unaizorrilla modified the milestones: Esquio-5, Future Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core help wanted Extra attention is needed UI
Projects
None yet
Development

No branches or pull requests

1 participant