-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conan Requirement is (>=1.60.0 <2 || >=2.0.5) | Rippled 2.1.0 #4926
Comments
I don't think any Conan 2.x will work. We should change the documentation to state the Conan requirement is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Description
The instructions to build Rippled state that it should need 1.55, but using 1.56 wont work, and the new GRPC binary requires a higher Conan.
Docs in the build need changing for the conan version
Steps to Reproduce
docker run -it -v $HOME/Downloads:/mnt thejohnfreeman/rippled-build-ubuntu:12e19cd9034b
git clone -b 2.1.0 --progress https://github.com/XRPLF/rippled
cd rippled
mkdir .build && cd .build
conan profile new default --detect
conan profile update settings.compiler.cppstd=20 default
conan install .. --output-folder . --build missing --settings build_type=Release
Failure:
Expected Result
Actual ripple would build a release
Actual Result
Got an error due to a depenency from a conanfile that requires 1.60 or higher
Environment
Ubuntu 22, Dockerized
Thanks
Thanks to @thejohnfreeman for his amazing container! second time using it and it works flawlessly. I actually downloaded the repo and changed the version of conan to 1.60
conan_version=${CONAN_VERSION:-1.63}
and it worked without any issues. Conan 2.1.0 doesn't work.The text was updated successfully, but these errors were encountered: