Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - Lighthouse checks #47

Closed
wants to merge 2 commits into from
Closed

WIP - Lighthouse checks #47

wants to merge 2 commits into from

Conversation

halfghaninne
Copy link
Member

@halfghaninne halfghaninne commented May 18, 2019 •
edited by deweydell

Closes #6

Requested feedback

We're a bit stuck on Step 2 of the Lighthouse set up process.

Netlify is currently configuring to run on our repo in the Netlify admin GUI, but Lighthouse Bot wants us to trigger a deploy using a ./deploy.sh executable.

How do we configure Lighthouse to run in the Netlify staging environment?

Relevant docs/conversation:

Official Netlify build settings docs:

Conversation between some devs trying to do something similar:

@halfghaninne halfghaninne mentioned this pull request May 18, 2019
Open
2 tasks
coilysiren
coilysiren requested changes May 24, 2019
View reviewed changes
.travis.yml
- npm run build
env:
matrix:
secure: RBUY+C7OegZoLEAv0ukvFZlVQUN3PIHpNDiguJj66bBWVid8XHYRVLkmyxvN79VwR8zb5VPZmOHtFOnm6z5+AL9uCT/FEPBCJJ/uoglIszq1EW3zxv4pWRplrF25yM25QzfjmC9wy3GhQvpd9+OGDWPnXS0b2PjU2iC8Z+trJquXjN+maQ819cpeCAiw+gkmXhDWts/xSZK/OH2QhaEzhU1GBieFs8/mfhVIH84F3mPFPdoyoKsQqgwB1FK5FBCTvVAAkpjJnsbq2OZQebIWonrt5lplmGMxbNmh4xZpVffdMIJzSdr2l7sjrYpTjZkTvSOz+3vq7T1zK8+gn2Swpi0U1AZ18746QxUrPqfcuYxBk5BWnbHqYrjb28xVmAHen4jouUzT99g6tB1GMKmXNMMC2ey8WsxgBfh+JgOXhnzANOfTNZo0RMV/z0OZJp19LrFgfzvpmqiIdtraErT3ZpkJaIpNJaBZAOeqLvoBVdSeKDBtscPleW7HOMtteltFcN0l2l6R0fdl7gwkjvP1BP+sc0lFOEmzhzq16O736UeW8JfwbEGHyUXWkrnsC6pfsMhgQp4UBnclOlkMuCDSAZXlypY39vPMY1FNAAZGk6gce1kO132NBy2CWkt+Ibk/r+mXUsub2cVjBpAhtVKOvdGsbjOXzEm3eU29EXeWZZs=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small blocking comments here:

  • Can you add a comment saying something like "this is the encrypted LIGHTHOUSE_API_KEY"
  • Add add it to env: global: rather than env: matrix

@coilysiren
Copy link
Member

So we currently deploy PR builds via Netlify. So the key here isn't to add a deploy.sh to deploy a 2nd PR build, its to hook a lighthouse call into the existing deploy script. @halfghaninne I'll look getting that working this weekend. I think its going to end up looking a lot like decaporg/gatsby-starter-decap-cms#218, yea

@coilysiren coilysiren self-assigned this May 30, 2019
@coilysiren
Copy link
Member

I'm gonna figure out the deploy script stuff (hopefully soon ^^) so I'm assigning myself to this issue

@coilysiren coilysiren mentioned this pull request Jun 25, 2019
Closed
@coilysiren
Copy link
Member

Hi friends <3 I can't find the space in my well of motivation to help with this particular PR - setup for nodejs apps is just a bit too far out of my comfort zone 🙏🏼

@deweydell
Copy link
Contributor

@halfghaninne I'm going to close this for now. Lighthouse is not a priority, but I think we can refer to this PR and re-open if and when someone has the bandwidth or interest to continue with it.

@deweydell deweydell closed this Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coilysiren coilysiren coilysiren requested changes

@deweydell deweydell Awaiting requested review from deweydell deweydell is a code owner

Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run Lighthouse checks during CI
3 participants
@halfghaninne @coilysiren @deweydell