Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server should 400 reject malformed pbuffer request #1886

Open
2 tasks done
brunobowden opened this issue Dec 26, 2020 · 0 comments
Open
2 tasks done

Server should 400 reject malformed pbuffer request #1886

brunobowden opened this issue Dec 26, 2020 · 0 comments
Labels
server AppEngine server component source:team From active team members
Milestone

Comments

@brunobowden
Copy link
Collaborator

Summary

The following is invalid protocol buffer request that receives a 200 response but instead should get a 400 response bad request.

$ curl -i \
  -H 'Content-Type: application/json' \
  -H 'Who-Client-ID: 00000000-0000-0000-0000-000000000000' \
  -H 'Who-Platform: WEB' \
  -X POST 'https://staging.whocoronavirus.org/WhoService/getCaseStats' \
  -d '{ jurisdictions: [ { jurisdictionType: COUNTRY, INVALID: US } ] }'

HTTP/2 200 
content-type: application/json
x-cloud-trace-context: a62ac816e2fd1dce274ef2ad5d95ecb8;o=1
date: Sat, 26 Dec 2020 20:47:16 GMT
server: Google Frontend
content-length: 67
via: 1.1 google
alt-svc: clear

{"jurisdictionStats":[{"lastUpdated":0,"timeseries":[]}],"ttl":600}% 

Checklist:

@brunobowden brunobowden added server AppEngine server component source:team From active team members labels Dec 26, 2020
@brunobowden brunobowden added this to the vGlobal milestone Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server AppEngine server component source:team From active team members
Projects
None yet
Development

No branches or pull requests

1 participant