-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bookmark importer does not rate limit #1232
Comments
Thanks David for the suggestion. Will take it up. A workaround for now is to re-do the import later and check the box "include failed urls" |
true - Unfortunately the import link disappears after the first import into a space. And when i try to generally do an import the importer does not detect that files where already imported (i did an html import ) |
Davidiusdadi
changed the title
bookmark importer does rate limit
bookmark importer does not rate limit
Mar 1, 2022
So the link is imported, but the content not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If reporting a bug:
Can you describe the problem and bug in more detail?
I have a lot of https://news.ycombinator.com/item links in my bookmarks and during importing get 503 errors.
I bet it is because you guys are not throtteling requests by domain.
How can we replicate the issue?
bookmark a couple dozed HN links and try to import
Expected behavior (i.e. solution)
not more than X requests to any specific domains should be made.
Error stack (from extension crash page)
nope
Other comments
You should make sure that your users can not DOS the sites that they love!
Just limiting the max number of parallel requests is not enough.
The text was updated successfully, but these errors were encountered: