Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip to content link bypasses critical content #383

Open
joedolson opened this issue Jul 19, 2022 · 2 comments
Open

Skip to content link bypasses critical content #383

joedolson opened this issue Jul 19, 2022 · 2 comments
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc

Comments

@joedolson
Copy link

On the News site, significant content is included in the header element. This is particularly noticeable on Podcast episodes, where the player and download link are contained in the header. This causes the skip link to bypass the primary content of the page.

@ryelle ryelle added the Accessibility Issues related to keyboard navigation, screen readers, etc label Jul 20, 2022
@ryelle
Copy link
Contributor

ryelle commented Jul 20, 2022

Should that content — the post entry-header header — be inside the main? The skip link code looks for that main element, so we could either update the skip code to look for a different element, or move the main to wrap the header content.

I'm leaning to moving the main wrapper one level up, since it's also used as the main landmark, but that will probably require CSS changes too.

@joedolson
Copy link
Author

I'd move it into main, yes. The single-post views for podcasts end up with two banner landmarks, because the second header element isn't nested inside a semantic container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc
Projects
None yet
Development

No branches or pull requests

2 participants