Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Bring your own secrets / Environment variables from query string #2099

Open
maxschmeling opened this issue Dec 17, 2024 · 1 comment
Open
Labels

Comments

@maxschmeling
Copy link
Contributor

I had a discussion with @brandonpayton and he suggested I log a ticket for public discussion.

What I'm proposing isn't necessarily just for secrets, but that's the primary use case from which this RFC stems.

I would like to be able to loading a playground using a publicly accessible blueprint, but provide some config (secrets, primarily) through the URL. For my use case, we could provide a blueprint for demoing Remote Data Blocks that includes a full Shopify integration with custom configuration, and all the person loading it would need to do is provide a token in the URL.

e.g. https://playground.wordpress.net/?blueprint-url=https://raw.githubusercontent.com/automattic/remote-data-blocks/trunk/blueprints/latest-shopify/blueprint.json&SHOPIFY_TOKEN=abc123

This could potentially be implemented as a step that has to be added to the blueprint in order for the value to be made available (naming needs some work):

{
  "step": "envVarFromQueryString",
  "queryStringKey": "SHOPIFY_TOKEN",
  "envVarName": "SHOPIFY_TOKEN"
}
@maxschmeling
Copy link
Contributor Author

@brandonpayton also pointed me to the discussion in #1703 which is very similar. But I wanted to log this still in case the use case or proposed implementation sparks additional discussion.

@adamziel adamziel moved this from Inbox to Needs review in Playground Board Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs review
Development

No branches or pull requests

2 participants