Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Required attribute to username and password field in wp_login_form #6352

Closed
wants to merge 7 commits into from

Conversation

Rcreators
Copy link

'required_username' and 'required_password' added to defaults. By default, both are set to false. So required attribute will not add to input fields. If set to true in $args for wp_login_form(), it will add the required attribute to the respective input field.

Trac ticket: https://core.trac.wordpress.org/ticket/60062


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Apr 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rcreators, joedolson, rajinsharwar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Apr 3, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the two new array parameters to the wp_login_form() function docs.

@joedolson
Copy link
Contributor

E.g.

 *     @type bool   $required_username Whether the username field has the 'required' attribute. Default false.
 *     @type bool   $required_password Whether the password field has the 'required' attribute. Default false.

src/wp-includes/general-template.php Outdated Show resolved Hide resolved
@Rcreators
Copy link
Author

@joedolson Can you check and approve changes?

src/wp-includes/general-template.php Show resolved Hide resolved
src/wp-includes/general-template.php Outdated Show resolved Hide resolved
src/wp-includes/general-template.php Outdated Show resolved Hide resolved
@Rajinsharwar
Copy link

@Rcreators Added some comments if you can review please.

@Rcreators
Copy link
Author

@Rajinsharwar Requested changes amended.

@audrasjb
Copy link
Contributor

@audrasjb audrasjb closed this Jun 11, 2024
@Rcreators Rcreators deleted the #60062 branch June 11, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants