Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multisite support for admin page #64

Open
felixarntz opened this issue Jan 25, 2023 · 9 comments · May be fixed by #690
Open

Add multisite support for admin page #64

felixarntz opened this issue Jan 25, 2023 · 9 comments · May be fixed by #690
Labels
[Type] Enhancement A suggestion for improvement of an existing feature WP Admin Issues for the WP Admin screen

Comments

@felixarntz
Copy link
Member

felixarntz commented Jan 25, 2023 •
edited
Loading

Is your enhancement related to a problem? Please describe.

The admin screen from #32 and the plugin action link from #36 are not fully working in multisite yet, or rather, they are limited to the individual site's WP Admin UI. We should expand that so that the same admin screen works in the Network Admin UI as well.

This is particularly critical, since on some multisite configurations regular administrators are not allowed to control plugins.

Acceptance Criteria

  • The admin page class from Create Tools page #32 should be expanded to also add the same admin screen on the network_admin_menu action hook.
    • The admin page added can behave the same way for now, but since the "Tools" menu does not exist in the Network Admin, we should add the screen in the "Settings" menu there (i.e. use add_submenu_page() with settings.php).
  • The plugin action links from Introduce a “Check this plugin” link in the Plugins list table #36 should be expanded to also show up in the Network Admin via the network_admin_plugin_action_links filter.
    • Particular attention has to be paid to the URL, since the page lives under settings.php here (instead of options-general.php in the regular WP Admin).

Test Coverage

  • Ensure the admin page is added propertly when using the Network Admin specific action.
  • Ensure the plugin link is added properly when using the Network Admin specific filter.
@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature WP Admin Issues for the WP Admin screen labels Jan 25, 2023
@felixarntz felixarntz moved this to AC Review in Plugin Check Jan 25, 2023
@felixarntz
Copy link
Member Author

@jjgrainger Opened this additional issue for the future, with ACs to review.

@jjgrainger jjgrainger moved this from AC Review to To Do in Plugin Check Feb 17, 2023
@jjgrainger jjgrainger removed their assignment Feb 17, 2023
@eclarke1
Copy link

Would it be possible to please assign an estimate to this one @jjgrainger ?

@jjgrainger jjgrainger added the 7 label Feb 21, 2023
@eclarke1 eclarke1 modified the milestones: Sprint 6, Sprint 7 Feb 22, 2023
@vishalkakadiya vishalkakadiya moved this from To Do to In Progress in Plugin Check Feb 28, 2023
@vishalkakadiya vishalkakadiya self-assigned this Feb 28, 2023
@vishalkakadiya vishalkakadiya mentioned this issue Feb 28, 2023
Closed
@vishalkakadiya vishalkakadiya linked a pull request Feb 28, 2023 that will close this issue
WIP: Add multisite support for admin page #94
Closed
@vishalkakadiya vishalkakadiya moved this from In Progress to Code Review in Plugin Check Feb 28, 2023
@vishalkakadiya
Copy link

@felixarntz @joemcgill @jjgrainger I have raised PR for this task here. Thanks!

@felixarntz
Copy link
Member Author

@vishalkakadiya @jjgrainger @eclarke1 Apologies for just spotting now that this is in milestone 1. I'm not sure that's a good idea because adding multisite support will entail more than this (e.g. making the AJAX requests correctly), and some of those other things will be more complicated. So if we only implement this issue, we would have a broken multisite support, which is probably worse than no multisite support at all.

I think we should focus on this only after we have a first working version and the repo is in the WordPress organization.

@eclarke1
Copy link

Thanks @felixarntz I have removed Milestone 1 and added Milestone 2, presumably this can sit in CR until such a time it's needed. Or do you think it may need additional work, and therefore should be moved back to AC?

@felixarntz
Copy link
Member Author

@eclarke1 I think it can remain in CR, it's just that we will need to work on additional issues to get full multisite support, and those need to be explored and defined eventually. Maybe we can eventually work on it in a feature branch.

@vishalkakadiya
Copy link

vishalkakadiya commented Feb 28, 2023 •
edited
Loading

I have updated the PR status from open to draft so we don't merge it accidentally. 🙂

@eclarke1 eclarke1 modified the milestones: Sprint 7, Sprint 6 Mar 1, 2023
@vishalkakadiya
Copy link

I'm assigning this to @jjgrainger, so he can continue on this once we unblock. Thanks!

@vishalkakadiya vishalkakadiya moved this from Code Review to To Do in Plugin Check Mar 2, 2023
@eclarke1 eclarke1 moved this from To Do to AC Review in Plugin Check Apr 24, 2023
@davidperezgar davidperezgar removed a link to a pull request Oct 2, 2024
WIP: Add multisite support for admin page #94
Closed
@davidperezgar davidperezgar linked a pull request Oct 2, 2024 that will close this issue
Open
@davidperezgar davidperezgar linked a pull request Oct 2, 2024 that will close this issue
Added support to multisite #690
Open
@davidperezgar
Copy link
Member

Hey, I've recored this issue to continue the development from last time.

@swissspidy swissspidy mentioned this issue Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Enhancement A suggestion for improvement of an existing feature WP Admin Issues for the WP Admin screen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support to multisite WordPress/plugin-check
6 participants
@swissspidy @jjgrainger @felixarntz @vishalkakadiya @davidperezgar @eclarke1