-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 3.8.0 release #1827
Prepare 3.8.0 release #1827
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/3.8.0 #1827 +/- ##
==============================================
Coverage 65.86% 65.86%
==============================================
Files 88 88
Lines 6855 6855
==============================================
Hits 4515 4515
Misses 2340 2340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pending release diffs (including #1826):
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@@ -130,7 +130,7 @@ function_exists( 'perflab_server_timing_use_output_buffer' ) | |||
* | |||
* This is only used when WP_DEBUG is enabled. | |||
* | |||
* @since n.e.x.t | |||
* @since 1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to have these set to 1.0.0
, but worth noting that this requires using a different version than is used for the release. I'm only flagging this since it would be important to know if anyone else than you or I run one of the next releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is according to the handbook:
In addition to those locations, run the
npm run since
command to replace any occurrence of@since n.e.x.t
with the version number located in thereadme.txt
file’sStable tag
. This ensures any code annotated with the “n.e.x.t” release will now have its proper version number on it. The only exception to this are pre-releases, such as a beta or RC: For those, the stable version number should be used. For example, if the milestone is1.2.0-beta.2
, the version in e.g.@since
annotations in the codebase should still be1.2.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, just one minor note.
**Enhancements** | ||
|
||
* Add Site Health check for `Cache-Control: no-store` page response header which disables bfcache. ([1807](https://github.com/WordPress/performance/pull/1807)) | ||
* Add Site Health test to verify that static assets are served with far-future expires. ([1727](https://github.com/WordPress/performance/pull/1727)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit-pick: Seeing one changelog entry with check
and another with test
makes me think this should probably be aligned to use one or the other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 9183df9
Co-authored-by: felixarntz <[email protected]>
Fixes #1796.
Previously #1754.
The following plugins are included in this release:
speculation-rules
: v1.4.0optimization-detective
: v1.0.0-beta1webp-uploads
: v2.5.0embed-optimizer
: v0.4.1image-prioritizer
: v0.3.1performance-lab
: v3.8.0