Remove no-cache and max-age=0 from bfcache failure conditions
#1826
Conversation
westonruter
added
[Type] Bug
westonruter
requested review from
mukeshpanchal27 and
felixarntz
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/3.8.0 #1826 +/- ##
================================================
Coverage ? 65.86%
================================================
Files ? 88
Lines ? 6855
Branches ? 0
================================================
Hits ? 4515
Misses ? 2340
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@westonruter Great catch, LGTM! Just one non-blocking feedback.
| ) | ||
| ) | ||
| ), | ||
| __( "The <code>Cache-Control</code> response header for an unauthenticated request to the home page includes the <code>no-store</code> directive. This can affect the performance of your site by preventing fast back/forward navigations (via the browser's bfcache).", 'performance-lab' ), |
There was a problem hiding this comment.
Not a blocker, but for the code constructs using placeholders would be nice, since they shouldn't be translatable - plus it avoids the need for translators to deal with HTML in the string, which is always good if it can be avoided.
| __( "The <code>Cache-Control</code> response header for an unauthenticated request to the home page includes the <code>no-store</code> directive. This can affect the performance of your site by preventing fast back/forward navigations (via the browser's bfcache).", 'performance-lab' ), | |
| sprintf( | |
| /* translators: 1: header name, 2: problematic directive */ | |
| __( "The %1$s response header for an unauthenticated request to the home page includes the %2$s directive. This can affect the performance of your site by preventing fast back/forward navigations (via the browser's bfcache).", 'performance-lab' ), | |
| '<code>Cache-Control</code>', | |
| '<code>no-store</code>' | |
| ), |
There was a problem hiding this comment.
That works: ffa9c25 (with a couple tweaks)
Co-authored-by: Felix Arntz <[email protected]>
Summary
Fixes #1825