-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modern Image Formats: The alternate mime type images didn't add original image extension in image name #1661
Comments
@mukeshpanchal27 Have you verified where this comes from? I'm not sure if it's really a bug in our plugin or simply happens because Core handles MIME type changes in a different way. This problem, does it only happen when you don't use fallback images, or only when you use fallback images, or in both scenarios? This would be great to specify. |
It is only happened when don't use fallback images. |
In that case, I assume this is simply because Core is now handling the migration. To be fair, it already did before for images above the "big image threshold", so this isn't even entirely new behavior, we just never caught on to it, similar to #1634. So I would say this is not truly a bug, but since per #444 not including the original file suffix in the file name could lead to problems, we should probably raise this upstream in Core, as I believe it should apply there too. Let's see if we can recreate the problem with Core alone. |
Bumping from December release. |
Given this seems mostly a Core problem at this point, we should probably remove this from any milestone for now? @mukeshpanchal27 I don't recall, did you already open a Trac ticket about this? |
Bug Description
While i doing smoke testing for plugin release i found that the uploaded image didn't add original image extension(
-jpeg
or-jpg
) in the full and sub-sizes image. For sub-size previously i reported #1560. After 6.7 the full size image also didn't get the image extension.In #444 we added the original image's extension to the WebP file name to ensure it is unique but after 6.7 the original issue reintroduce.
Image.jpeg
Image.jpg
Steps to reproduce
Modern Image Formats
plugin.Screenshots
The text was updated successfully, but these errors were encountered: