Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Duplicate Entries for 19.7.0 in changelog.txt #68836

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

im3dabasia
Copy link
Contributor

Closes : #68834

What?

This PR removes duplicate entries for the 19.7.0 release in changelog.txt.

Why?

The changelog contains duplicate entries for the 19.7.0 release at two different locations, introduced by separate autogenerated commits. Removing the duplicates ensures a clean and accurate changelog.

How?

Identified and removed the redundant entries while keeping the correct structure intact.

@im3dabasia im3dabasia marked this pull request as ready for review January 22, 2025 16:51
Copy link

github-actions bot commented Jan 22, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@im3dabasia
Copy link
Contributor Author

@afercia ,

When you have a moment, please review my PR.

@afercia
Copy link
Contributor

afercia commented Jan 24, 2025

Thanks @im3dabasia I'd suggest to ping teams e.g. @WordPress/gutenberg-core rather than individual contributors because of limited bandwidth individuals may have. Pinging a team gives a higher chance to get a review :)

@t-hamano t-hamano added the [Type] Build Tooling Issues or PRs related to build tooling label Jan 25, 2025
@im3dabasia
Copy link
Contributor Author

Thank you, @afercia, for the suggestion.

I am trying to ping @WordPress/gutenberg-core, but I don't think I have the permissions to tag them. I say this because when I type @ followed by WordPress/, I don’t see the option to select gutenberg-core, as I do with individual contributors like you.

@afercia
Copy link
Contributor

afercia commented Jan 27, 2025

I don’t see the option to select gutenberg-core, as I do with individual contributors like you.

Oh, interesting. Thanks for reporting it @im3dabasia.
@desrosj or @Mamaduka when you have a chance: do you know whether the ability to ping groups is restricted to some users and why?

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to merge. #62650 also altered changelog.txt "manually".

P.S. Unfortunately, I don't have details on why project teams can't be pinged. It could be a general GH option.

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 27, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 27, 2025
@Mamaduka Mamaduka merged commit c8a8df3 into WordPress:trunk Jan 27, 2025
69 of 70 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.2 milestone Jan 27, 2025
@t-hamano
Copy link
Contributor

do you know whether the ability to ping groups is restricted to some users and why?

Maybe mention is only available to members of WordPress Organization.

See: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#mentioning-people-and-teams

@im3dabasia
Copy link
Contributor Author

im3dabasia commented Jan 27, 2025

P.S. Unfortunately, I don't have details on why project teams can't be pinged. It could be a general GH option.

Got it, thanks @Mamaduka!

Related: https://docs.github.com/en/organizations/organizing-members-into-teams/about-teams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up changelog.txt from duplicate entries
4 participants