Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inserter: Add loading state and refactor pattern #68235

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Inserter: Add loading state and refactor pattern #68235

wants to merge 1 commit into from
+34 −7

Conversation

SainathPoojary
Copy link
Contributor

@SainathPoojary SainathPoojary commented Dec 23, 2024 •
edited by Mamaduka
Loading

Closes: #68232

What?

This PR improves the user experience in the block inserter by introducing a proper loading state for pattern categories. Instead of displaying “No results found” during loading, a spinner is now shown to indicate that the categories are being fetched.

Why?

Previously, the interface displayed “No results found” while pattern categories were still loading, which could confuse users. Adding a spinner provides clearer feedback and enhances the user experience.

How?

  1. Refactored usePatternCategories to return an object with categories and isLoading.
  2. Updated BlockPatternsTab to show a spinner while categories are being fetched instead of displaying “No results found.”
  3. Refactored PatternsExplorer and PatternCategoryPreviews to destructure categories from the hook’s response.
  4. Added styles to center the spinner in the block patterns tab during loading.

Testing Instructions

  1. Refactored usePatternCategories to return an object with categories and isLoading.
  2. Updated BlockPatternsTab to show a spinner while categories are being fetched instead of displaying “No results found.”
  3. Refactored PatternsExplorer and PatternCategoryPreviews to destructure categories from the hook’s response.

Screenshots or screencast

Before:

Screen.Recording.2024-12-23.at.12.30.27.PM.mov

After:

Screen.Recording.2024-12-23.at.12.28.34.PM.mov

@SainathPoojary
Inserter: Add loading state and refactor pattern
1a46499 
- Added isLoading to usePatternCategories with spinner support in BlockPatternsTab.
- Refactored PatternsExplorer and PatternCategoryPreviews to destructure categories.
- Updated styles for loading spinner alignment.
@SainathPoojary SainathPoojary marked this pull request as ready for review December 24, 2024 11:25
@github-actions GitHub Actions
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SainathPoojary <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: annezazu <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zoom out: when using to add a new page, inserter initially shows "no results found"
1 participant
@SainathPoojary