Disable Zoom Out if no section root to allow for Theme opt in - 6.7 #68229
+437
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +38 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
I would like to discuss whether this PR should be shipped to WP 6.7.2. This PR disables zoom out mode when there is no section root. This means that in the post editor, zoom out mode will be disabled regardless of whether it is an iframe editor or not, which will resolve the issue reported in #66884. However, I'm concerned that making such a change in a minor release may have a bit of a big impact. |
|
I also left a comment on the PR: #67232 (comment). This change makes the Zoom out feature's availability inconsistent. The conditions are implicit and not communicated with the end user. P.S. The Zoom out feature gets enabled for posts if you add a group and set the element as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Backports #67232 to
wp/6.7for 6.7.2 release.