Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Link UI anchor position in Navigation block submenus #68182

Open
getdave opened this issue Dec 20, 2024 · 2 comments · May be fixed by #68236
Open

Improve Link UI anchor position in Navigation block submenus #68182

getdave opened this issue Dec 20, 2024 · 2 comments · May be fixed by #68236
Labels
[Block] Navigation Affects the Navigation Block [Block] Submenu Affects the Submenu Block - for submenus in navigation [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Dec 20, 2024

What problem does this address?

When creating menu items within submenus within the Navigation block the Link UI popover will remain open after the link is created. This is intentional in order to allow users to then adjust the settings of the link (e.g. Open in new tab).

However, the popover can obscure the + button inserter.

What is your proposed solution?

Either

  • improve the anchor positioning of the Link UI so that it takes into account the submenu (note there was work to do the same for the block toolbar recently).
  • hide the Link UI following creation - note however that this would require another click to modify any link settings. User feedback was that this was suboptimal so we should be careful before changing this behaviour.
@getdave getdave added [Block] Navigation Affects the Navigation Block [Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Enhancement A suggestion for improvement. labels Dec 20, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 23, 2024
@snehapatil2001
Copy link
Contributor

Hey @getdave, Thank you for raising this issue!

  • I’ve tested the current behaviour, and I’d like to share a video demonstration to show that after clicking on a submenu item, the popover disappears, and the + button becomes visible again.

  • Given this behaviour, it seems that no changes are necessary to address this issue.

Screen.Recording.2024-12-23.at.1.05.54.PM.mov

Hey @yogeshbhutkar

  • I’ve reviewed your implementation, and I wanted to share some feedback based on my testing. If there are multiple submenus, the current margin-top logic does not work consistently.

  • For example, when opening the popover on a submenu item, it can still obscure the + button of other sub-items. Please see the attached video:

Screen.Recording.2024-12-23.at.1.56.19.PM.mov

@yogeshbhutkar
Copy link
Contributor

Yes @snehapatil2001, I believe you're right here. I kind of only took into consideration the last element. But, that shouldn't be the case. I think we'll need to update the logic of calculating the positions a bit. I’m working on it now and will share an update once it’s ready.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Submenu Affects the Submenu Block - for submenus in navigation [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
3 participants