Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs: design / UX audit ahead of stabilization #68149

Open
Tracked by #52997
ciampo opened this issue Dec 19, 2024 · 2 comments
Open
Tracked by #52997

Tabs: design / UX audit ahead of stabilization #68149

ciampo opened this issue Dec 19, 2024 · 2 comments
Labels
Needs Design Feedback Needs general design feedback. [Package] Components /packages/components

Comments

@ciampo
Copy link
Contributor

ciampo commented Dec 19, 2024

As we'd like to stabilize the Tabs component soon (#52997), we'd like to get the green light from @WordPress/gutenberg-design in terms of the component's design and UX.

Most importantly, let's try to in terms of future compatibility — are there any aspects of the component as of today that would need changing in the future, and would that change be a breaking change? If so, let's address it before stabilizing. (for example, are we good with how the component currently handles overflowing tabs by showing a horizontal scrollbar?)

cc @WordPress/gutenberg-components

@ciampo ciampo added [Package] Components /packages/components Needs Design Feedback Needs general design feedback. labels Dec 19, 2024
@jameskoster
Copy link
Contributor

It's not perfect, but I think horizontal scrolling is acceptable, and preferable to other techniques like wrapping the tabs. It's also fairly standard practise across design systems. It may be that we add left/right buttons to assist when scrolling is uncomfortable (see example), but that needs investigation.

We may also need to make a change to the styling of active tabs in vertical orientation. In the recent update there was consensus that showing the chevron on hover/focused/selected tabs was an adequate 'shape change' in terms of indicating the different states. But in #55730 an argument is made that the chevron should be present on the resting state too because as it indicates the behavior of opening a 'subpanel'. If that's the case we'll need a different shape change (or some other treatment that satisfies contrast requirements) for the selected tab. This all relates a bit to #66448, and is probably better discussed there :)

I don't consider either of these to be breaking changes.

@ciampo
Copy link
Contributor Author

ciampo commented Dec 20, 2024

I agree. I also think that neither of those changes would be considered as breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Package] Components /packages/components
Projects
None yet
Development

No branches or pull requests

2 participants