Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render control to iterate through section styles in zoom out #66465

Open
jasmussen opened this issue Oct 25, 2024 · 5 comments · May be fixed by #67140
Open

Render control to iterate through section styles in zoom out #66465

jasmussen opened this issue Oct 25, 2024 · 5 comments · May be fixed by #67140
Assignees
@matiasbenedetto
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress

Comments

@jasmussen
Copy link
Contributor

jasmussen commented Oct 25, 2024 •
edited by richtabor
Loading

One of the benefits of iterations to the shuffle control as outlined in #66105, besides the addition of more overt control, is the control this also gives you when using the Write tool.

In expanding on this, section styles would be nice to have directly accessible there, in context, so you can choose both your design, and a section style, at the same time. Mockup:

Image

In this mockup, a multi-color swatch, as is currently used also for the image duotone control, is used to represent a section style (background and text colors).

Selecting the control will iterate through the section styles.
@jasmussen jasmussen mentioned this issue Oct 25, 2024
Closed
@richtabor richtabor changed the title Zoom out shuffle: also show section style control Render control to iterate through section styles in zoom out Oct 25, 2024
@mtias
Copy link
Member

mtias commented Oct 27, 2024

Should we consider using the plain icon of global styles without including colors? I'm slightly worried that representation overlaps with duotone circles a little bit.

Another alternative we had way back then:

Image

@mtias mtias added the Needs Design Feedback Needs general design feedback. label Oct 27, 2024
@jasmussen
Copy link
Contributor Author

Can work. Here's a fresh take on that.

Image

@mtias mtias added the [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced label Oct 29, 2024
@richtabor
Copy link
Member

Should we consider using the plain icon of global styles without including colors? I'm slightly worried that representation overlaps with duotone circles a little bit.

Downside of this implementation is that only one color can be expressed (background color). Perhaps that's fine?

@jasmussen
Copy link
Contributor Author

Perhaps that's fine?

It probably is, but we can also just start here, and then evolve if the need arises.

@richtabor richtabor mentioned this issue Nov 8, 2024
Closed
@matiasbenedetto matiasbenedetto linked a pull request Nov 19, 2024 that will close this issue
Open
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 19, 2024
@matiasbenedetto
Copy link
Contributor

Potential implementation for this: #67140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matiasbenedetto matiasbenedetto

Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add section styles switch button in block toolbar in zoom out mode WordPress/gutenberg
4 participants
@mtias @jasmussen @matiasbenedetto @richtabor