You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No files outside of the WordPress/Blueprints repository (or reasonable wp.org URLs) are referenced
Does the Blueprint come with a clear title and description?
Do the automated GitHub checks pass?
Does the Blueprint actually work when previewed? Does it load reasonably fast? Are there any errors in the browser devtools?
What to do next?
If the answer to all these questions is "yes", you can just merge the Pull Request. The gallery will be automatically refreshed by a CI job. You're done!
If the answer to any of these questions is "no":
Leave feedback for the person submitting the Pull Request.
Tell them exactly what's wrong and give them tips on how to improve it. Over time we should accumulate a nice "copy&paste" database of those tips to streamline the process.
If they reply, re-review.
If they don't reply within 14 days, close the PR.
This simple workflow may suffice. If it doesn't, let's explore:
Automatically adding "awaiting review" and "needs changes" labels when the PR is created and commented on
A project board with columns representing PRs with those labels
The text was updated successfully, but these errors were encountered:
Let's co-create a Blueprint review checklist for the future reviewers. Here's the initial draft:
How to get started?
What to review?
How to review?
What to do next?
If the answer to all these questions is "yes", you can just merge the Pull Request. The gallery will be automatically refreshed by a CI job. You're done!
If the answer to any of these questions is "no":
This simple workflow may suffice. If it doesn't, let's explore:
The text was updated successfully, but these errors were encountered: