Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint review checklist #42

Open
7 tasks
adamziel opened this issue Apr 25, 2024 · 0 comments
Open
7 tasks

Blueprint review checklist #42

adamziel opened this issue Apr 25, 2024 · 0 comments

Comments

@adamziel
Copy link
Contributor

adamziel commented Apr 25, 2024

Let's co-create a Blueprint review checklist for the future reviewers. Here's the initial draft:

How to get started?

  • Subscribe to all the new PRs and issues in this repository to get notifications about new submissions

What to review?

  • New Pull Requests without any labels
  • Pull Requests with a "needs review" label

How to review?

  • Does the PR fulfill the contribution guidelines?
    • It has a dedicated directory for the Blueprint
    • There's only a single Blueprint.json file
    • No files outside of the WordPress/Blueprints repository (or reasonable wp.org URLs) are referenced
    • Does the Blueprint come with a clear title and description?
  • Do the automated GitHub checks pass?
  • Does the Blueprint actually work when previewed? Does it load reasonably fast? Are there any errors in the browser devtools?

What to do next?

If the answer to all these questions is "yes", you can just merge the Pull Request. The gallery will be automatically refreshed by a CI job. You're done!

If the answer to any of these questions is "no":

  • Leave feedback for the person submitting the Pull Request.
  • Tell them exactly what's wrong and give them tips on how to improve it. Over time we should accumulate a nice "copy&paste" database of those tips to streamline the process.
  • If they reply, re-review.
  • If they don't reply within 14 days, close the PR.

This simple workflow may suffice. If it doesn't, let's explore:

  • Automatically adding "awaiting review" and "needs changes" labels when the PR is created and commented on
  • A project board with columns representing PRs with those labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant