Display Past Generation Times in the Console

[koinkoin-project]

Hello

Advantages:

Avoid staying glued to the screen to ensure you don't miss the end of generations and can thus record the time of the much-awaited generation :)

[Woolverine94]

I agree. biniou definitely lacks this features, which will be very useful to produce metrics when testing new optimizations and confirm benefits of them.

I add this idea to the to-do-list.

[Woolverine94]

In the case of the chatbot, it's most likely the output of llama-cpp-python.

Modules based on diffusers / transformers (i.e. : most of them) doesn't display this information.

I've already implemented a working timer, but i'm trying now to extend this to a generic "metric" function that could send (in the future) other informations than generation time.

[koinkoin-project]

...which could (in future) send information other than generation time.

You've caught my attention: roughly what kind of information, and what about the output (console, text file)?

[Woolverine94]

Still don't have any precise idea, only "provisioning" this possibility.
Could be (maybe) RAM consumption, or any metrics that can be measured before and after inference.
Output could be console only, as it's easy to create a txt log file based on the console output.

[koinkoin-project]

I was thinking in the background and this came to mind:

• Record time in milliseconds (already implemented) + add time information for humans (e.g. 1 hour 54 minutes or 1 hour 11 minutes 34 seconds :)
• Write the prompt and as many options as possible in a txt file with the same name as the output file provided by biniou in /output)
• Save the file in the gradio browser (with a clickable link to launch an additional information file)
• Save the output file (with a clickable link to launch an image or video or txt file)

[Woolverine94]

Record time in milliseconds (already implemented) + add time information for humans (e.g. 1 hour 54 minutes or 1 hour 11 minutes 34 seconds :)

Why not, but not a priority. Seconds will be simpler to handle for benchmarks and comparisons.

Write the prompt and as many options as possible in a txt file with the same name as the output file provided by biniou in /output)
Save the file in the gradio browser (with a clickable link to launch an additional information file)
Save the output file (with a clickable link to launch an image or video or txt file)

Duplicates of console log features introduced in commit c7f10a5, pursued through commit 535da5c and which has to be finished for text, audio and 3d modules. The advantage of using the log output instead of txt files per generation is keeping track of the workflow through the modules.

[Woolverine94]

Commit da5c752 introduce this functionality for all modules.

[Woolverine94]

Hello @koinkoin-project,

File "/home/biniou/biniou/ressources/common.py", line 210, in safety_checker_sd print("Date et heure actuelles : ", datetime.datetime.now()) ^^^^^^^^ NameError: name 'datetime' is not defined

This is not my code ...

[koinkoin-project]

This is not my code ...

LOL, but I'd just done a Biniou update, weird there really are questions I wouldn't have answers to. It seemed to me that the Biniou updates were de facto overwriting my modifications. And I even had the impression that this was the second update that updated a lot of files (after deleting my local common.py file).

[Woolverine94]

The first step of the update script git pull the repo and does not use any kind of merging strategies. You should git checkout . before running the update script if you have made modifications ... and made them again after update. At this time, biniou is not thinked at all to merge users modifications within his code.

Anyway, even if I can't give you support on custom modifications of biniou (mostly because I do not have access to your code), it seems the error you encountered in the previous error message is a missing from datetime import datetime at the top of common.py.

[koinkoin-project]

Anyway, even if I can't give you support on custom modifications of biniou (mostly because I do not have access to your code), it seems the error you encountered in the previous error message is a missing from datetime import datetime at the top of common.py.

Don't worry, it was some badly screwed up time overlay tests in the console, and in a function where it seemed to me that all models passed... Your code is much better than mine :)

The first step of the update script git pull the repo and does not use any kind of merging strategies. You should git checkout . before running the update script if you have made modifications ... and made them again after update. At this time, biniou is not thinked at all to merge users modifications within his code.

I don't quite understand: if I make changes to the resources/common.py file tomorrow, for example, then the day after tomorrow I'll do a biniou update and my modified common.py won't be updated? As I write these lines, I know that I'm going to test more precisely to memorize the behavior and real impact of update.sh on my modifications to this common.py file.

[Woolverine94]

Don't worry, it was some badly screwed up time overlay tests in the console, and in a function where it seemed to me that all models passed... Your code is much better than mine :)

I can confirm that this function is NOT common to all models :D

I don't quite understand: if I make changes to the resources/common.py file tomorrow, for example, then the day after tomorrow I'll do a biniou update and my modified common.py won't be updated?

Yes, it won't be updated until you cancel your changes. There's a lot of informations in the log output while updating, but the first lines should mention that the git pull has failed because of changes you introduced (which is not a good thing at all, because the following update commands could needs the new revision of the files).

You should do a git checkout . to revoke your changes, followed by a git status to validate you're on a clean copy before using update.sh. Maybe there is also something to try with the autostash option of git pull, but i have no experience of it.

Anyway, biniou is not at this point designed to be modified, then updated with a merge of the changes and probably should never be.