Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide CMake building system #2

Open
1 of 2 tasks
Wohlstand opened this issue Aug 6, 2017 · 3 comments
Open
1 of 2 tasks

Provide CMake building system #2

Wohlstand opened this issue Aug 6, 2017 · 3 comments
Assignees

Comments

@Wohlstand
Copy link
Member

Wohlstand commented Aug 6, 2017

  • Make PGE File Library be buildable as static or dynamic library (as STL or as Qt variant)
  • Organize source code files and public include files into separated "include" and "src" folders

I think, we would drop away support for Qt variant after reorganizing of PGE Editor and use STL only variant which is much faster than Qt.
What do you think about this, @KevinW1998 ?

Also, make this library to be licensed under MIT.

@KevinW1998
Copy link
Contributor

I am fine with MIT license change and QVariant removal

@Wohlstand
Copy link
Member Author

Wohlstand commented Aug 6, 2017

As "variant" I meant version of library where are widely used QString QVector, and related types. For now it is dual STL and Qt made by bunch of macros

@KevinW1998
Copy link
Contributor

Yea, that's not really nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants