Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider contributing this to Emacs? #1

Open
phil-s opened this issue Oct 1, 2016 · 7 comments
Open

Consider contributing this to Emacs? #1

phil-s opened this issue Oct 1, 2016 · 7 comments

Comments

@phil-s
Copy link

phil-s commented Oct 1, 2016

Any tools directly related to elisp would be (especially) valuable to have as default functionality in Emacs.

Please do consider contributing this, while you still have only yourself to get permission from?

@Wilfred
Copy link
Owner

Wilfred commented Oct 1, 2016

This was mentioned on reddit too.

I'd be very willing to contribute it to Emacs: do you mean core, or GNU ELPA?

elisp-refs is heavily dependent on dash.el, but that's available on GNU ELPA. The other dependencies are not, but they're just conveniences.

I have a slight preference for giving it a month or two before trying to upstream it, just to get feedback etc. What do you think?

I'm also keen to keep development on GitHub, but that shouldn't be an issue (again, dash.el seems to cope).

@phil-s
Copy link
Author

phil-s commented Oct 2, 2016

I was thinking of core, but I hadn't noticed the dependencies. They might well mean GNU ELPA is the practical place. It would certainly be nice if elisp programming tools were in core by default, though.

I believe you'll need to be careful about accepting pull requests. If you start merging code from people who have not signed copyright assignment papers, it's surely going to cause you problems down the track if you do want to get this included in core or GNU ELPA.

It might be interesting to find out how dash manages that issue.

@Wilfred
Copy link
Owner

Wilfred commented Oct 3, 2016

dash.el still takes patches from anyone, as I understand it: https://twitter.com/magnars/status/764741295994724352

That said, company and lispy both require copyright assignment. I know abo-abo has an account on the fencepost system, so it's easy for him to discover whether PR authors have assigned copyright.

Anyway, what's the process to get into GNU ELPA?

@Wilfred
Copy link
Owner

Wilfred commented Nov 4, 2016

OK, I've got permissions on GNU ELPA, so I should be able to add elisp-refs there. I'll need to add loop.el (only written by me, should be easy) and look at removing the other dependencies.

Wilfred added a commit that referenced this issue Jan 11, 2018
This is the main blocker to #1.
@Wilfred
Copy link
Owner

Wilfred commented Jan 11, 2018

OK, this should now be possible :)

@skangas
Copy link

skangas commented Oct 1, 2021

Hi!

Any chance for having this available on GNU ELPA? I think the easiest way to submit it is to make a post to [email protected] explaining what it does and that you want to submit it (attach a copy of elisp-refs.el if that is practical). From there, you usually get help by someone who knows exactly how this should be set up.

@alphapapa
Copy link

alphapapa commented Oct 1, 2021

Having recently added taxy to GNU ELPA, I can suggest checking the readme. You can submit a patch to the packages file that adds the package directly, and then other-Stefan will take it from there and ask you to make any further changes that might be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants