Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global requires a polyfill. Shall we replace global with globalThis? #129

Open
brendonjohn opened this issue Feb 18, 2022 · 2 comments
Open

global requires a polyfill. Shall we replace global with globalThis? #129

brendonjohn opened this issue Feb 18, 2022 · 2 comments

Comments

@brendonjohn
Copy link

Hey there, I love the library.

From testing a library in stripped-down environments I've realised react-shadow assumes that global is available for accessing the global this value.

Do you have a suggested polyfill for making global available?

Alternatively, would you accept a PR to replace the use of global with globalThis? I'm happy to send the PR through.

image

https://caniuse.com/mdn-javascript_builtins_globalthis

This should be significantly better without needing to make an invasive change.

🙇
@brendonjohn
Copy link
Author

I see this has been resolved here: #121

@jclhandy
Copy link

jclhandy commented Apr 8, 2022

I think is a great experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brendonjohn @jclhandy