Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations not propagated on file uploads #11599

Open
2 tasks done
joubu opened this issue May 8, 2024 · 4 comments
Open
2 tasks done

Translations not propagated on file uploads #11599

joubu opened this issue May 8, 2024 · 4 comments

Comments

@joubu
Copy link
Contributor

joubu commented May 8, 2024

Describe the issue

I have uploaded a .po file for a given component that is supposed to propagate the changes, but other components didn't get their translations updated.
See below, I have uploaded the file for "main" and I as expecting the other versions to be updated as well.
Is that because the translation was fuzzy before the upload?

image

I found this commit 8d7edd7 that states that it should work.

Note that comment might need adjustments weblate/trans/models/translation.py:964 # We intentionally avoid propagating:

I already tried

  • I've read and searched the documentation.
  • I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

Have components configured for translation propagation and upload a file.

Expected behavior

No response

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

Docker container

Weblate versions

5.5.4-dev

Weblate deploy checks

No response

Additional context

No response

@joubu
Copy link
Contributor Author

joubu commented May 13, 2024

Update: I actually noticed later that the update didn't work at all when using the UI. It worked (without the propagation) using "wlc upload".

The UI timed out and it seems that the job has never been processed (or enqueued?).

nijel added a commit that referenced this issue May 13, 2024
This is no longer true since 8d7edd7, see #11599
@nijel
Copy link
Member

nijel commented May 13, 2024

It is supposed to propagate. Without further details, it is impossible to tell what happened.

  • Maybe the string was updated after that?
  • Permission issues?
  • Component was locked?
  • CLA not agreed (if in place)?

@joubu
Copy link
Contributor Author

joubu commented May 13, 2024

On this link you can see that "main" and "23.11" have been updated (23.11 was not before a second "wlc upload" for this specific version)
https://translate.koha-community.org/translate/koha/main/staff-prog/ar_ARAB/?checksum=8134165b32931905

23.05 and 22.11 are still using the old translation.

"Allow translation propagation" is turned on for all of them.

* Maybe the string was updated after that?

Nope.

* Permission issues?

No. And wlc uses a correct API key as 23.11 has been updated on the second run.

* Component was locked?

No components were locked.

* CLA not agreed (if in place)?

Not in place.

The component "staff-prog" is quite big and took hours to finish (at least to display the % progress).

I can eventually enable a debug mode and try again if you think it could be helpful.
I have looked at the docker logs output but haven't found anything useful.

 gunicorn stderr | [2024-05-10 07:08:25,313: INFO/2125] koha/23-11/staff-prog/ar_ARAB: committed ['/app/data/vcs/koha/23-11/installer/ar-Arab-staff-prog.po'] as "[hidden name]." <hiden email address]>[
 gunicorn stderr | [2024-05-10 07:08:28,348: INFO/2125] koha/23-11/staff-prog/ar_ARAB: processing ar-Arab-staff-prog.po, content changed, 10925 strings

@nijel
Copy link
Member

nijel commented May 14, 2024

I didn't notice the different behavior when using API or UI. The code used for upload is the same for both, so that doesn't explain the behavior. The only reason I can think of is that that component was locked at that point and that made Weblate skip the propagation there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants