Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot revert the approved strings #11373

Closed
2 tasks done
Geeyun-JY3 opened this issue Apr 8, 2024 · 6 comments
Closed
2 tasks done

Cannot revert the approved strings #11373

Geeyun-JY3 opened this issue Apr 8, 2024 · 6 comments
Labels
wontfix Nobody will work on this.

Comments

@Geeyun-JY3
Copy link
Collaborator

Geeyun-JY3 commented Apr 8, 2024

Describe the issue

Cannot revert the approved strings even though the user has permission to review strings.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

  1. Get permission to review the strings of a project
  2. Revert an approved string

Expected behavior

Able to revert the approved strings while the user has permission to review strings.

Screenshots

Example: https://hosted.weblate.org/translate/f-droid/website/zh_Hans/?checksum=440af90d7078d5eb#history
weblate_bug_cannot_revert_approved_string
image

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

Weblate 5.4.3

Weblate deploy checks

No response

Additional context

No response

@nijel
Copy link
Member

nijel commented Apr 9, 2024

Reverting does revert to that translation, it does not revert that edit. So if you click on a change which matches the current translation, it does nothing.

I think there was a discussion somewhere how revert should behave, but I can't find it right now.

Copy link

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label Apr 24, 2024
@Geeyun-JY3
Copy link
Collaborator Author

Reverting does revert to that translation, it does not revert that edit. So if you click on a change which matches the current translation, it does nothing.

What do you mean? I don't really understand.

@nijel
Copy link
Member

nijel commented Apr 24, 2024

Reverting brings you to the state of the string after the change where you've clicked on revert.

@github-actions github-actions bot removed the wontfix Nobody will work on this. label Apr 25, 2024
@Geeyun-JY3
Copy link
Collaborator Author

Reverting brings you to the state of the string after the change where you've clicked on revert.

You mean the issue I encounter here is related to the approved state of this string?

Copy link

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label May 10, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix Nobody will work on this.
Projects
None yet
Development

No branches or pull requests

2 participants