Skip to content
This repository has been archived by the owner on Jul 3, 2021. It is now read-only.

Integrate Storybook #22

Open
michealengland opened this issue Mar 18, 2020 · 3 comments
Open

Integrate Storybook #22

michealengland opened this issue Mar 18, 2020 · 3 comments
Assignees
@elpuas @michealengland
Labels
blocked enhancement New feature or request help wanted Extra attention is needed

Comments

@michealengland
Copy link
Contributor

Add storybook to this project to make it easy for engineers to make their component shareable.
@michealengland michealengland added the enhancement New feature or request label Mar 18, 2020
@gregrickaby
Copy link
Contributor

gregrickaby commented Mar 18, 2020 •
edited
Loading

Piling on that this should mirror how Gutenberg does it since we're using @wp-scripts

@michealengland michealengland self-assigned this Apr 11, 2020
michealengland pushed a commit that referenced this issue Apr 11, 2020
Update package & lock
1619bef 
- Remove babel dev dependencies already included in WP Scripts.
- Move @storybook/cli to dev dependencies.

See #22 (comment)
@michealengland
Copy link
Contributor Author

I picked up this issue and made some minor adjustments to what has been done so far.

Updates:

  • Merged in the latest version and modified some whitespace changes that happened in package.json
  • Tested / removed babel packages since these are included in WP Scripts
  • Troubleshooted NPM issue, I had various issues with NPM not running while making some changes and this appears to be working smoother now
  • Began working on ways to incorporate the Rich Text block in as a starting block.
  • Added the Storybook to the README Doc

I've still got some work to do, figuring out how to get WP Scripts into the Storybook directory.

@michealengland
Copy link
Contributor Author

Going to block this for now as something to circle back to.

Currently, I'm unsure how to incorporate WP Scripts packages into Storybook. I'll keep an eye out in the meantime and will unblock if something promising is revealed.

@michealengland michealengland added blocked help wanted Extra attention is needed labels May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@elpuas elpuas

@michealengland michealengland

Labels
blocked enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gregrickaby @elpuas @michealengland