-
|
When you first start up WebCrate, it prompts you to name your instance. Currently, after you enter a name, you have to click the "Next Step" button. It makes more sense to allow the user to click enter to proceed to the next page, in my opinion. I've made this change in my fork. What do you think? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 2 replies
-
|
Yeah that makes sense. Pressing enter is already used in other parts of the app to submit actions, like when adding a new link. Instead of If you create a PR with that change I'll merge it and include it in the next release. |
Beta Was this translation helpful? Give feedback.
-
|
Made the PR (#45)! |
Beta Was this translation helpful? Give feedback.
-
|
This is included in version 1.4.1 🎉 |
Beta Was this translation helpful? Give feedback.
Yeah that makes sense. Pressing enter is already used in other parts of the app to submit actions, like when adding a new link.
Instead of
keyup.enter, I'd prefer it if you use thevue-shortkeydirective which is already used in other parts of the app as well:webcrate/client/components/Modal/AddLink.vue
Line 22 in 6f3321d
If you create a PR with that change I'll merge it and include it in the next release.