Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] SIWE Issued At is undefined #2258

Closed
chris13524 opened this issue May 13, 2024 · 3 comments
Closed

[bug] SIWE Issued At is undefined #2258

chris13524 opened this issue May 13, 2024 · 3 comments
Labels
bug Something isn't working needs review

Comments

@chris13524
Copy link
Member

chris13524 commented May 13, 2024

Link to minimal reproducible example

https://lab.web3modal.com/library/wagmi-all/

Summary

Login with email

image

List of related npm package versions

latest

@chris13524 chris13524 added bug Something isn't working needs review labels May 13, 2024
Copy link

linear bot commented May 13, 2024

@wgcorrea
Copy link

I believe it's not a bug, and just the documentation is not covering all the getMessageParams possible arguments. Checking the source code, I can see that you can pass iat, which will work fine. E.g.:

	const getMessageParams = async () => ({
		domain: window.location.host,
		uri: window.location.origin,
		chains: [1],
		statement: 'Please sign with your account',
		iat: new Date().toISOString(),
	});

Tested with version 4.2.2

@chris13524
Copy link
Member Author

I believe it's not a bug

It is a bug. This field is required as per ERC-4361, so if it was a docs issue then not providing it should be a compile-time error. Second, even if it was optional, the field shouldn't be included at all instead of being an "undefined" string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs review
Projects
None yet
Development

No branches or pull requests

3 participants