Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] modal types doesn't use ariakit dialog types #2313

Open
jeromeraffin opened this issue Oct 2, 2023 · 1 comment
Open

[Modal] modal types doesn't use ariakit dialog types #2313

jeromeraffin opened this issue Oct 2, 2023 · 1 comment
Labels
existing-component tech

Comments

@jeromeraffin
Copy link
Contributor

For which component/foundations?

Modal

Prioritization

Medium ⛰️

Description

The modal component is based on ariakit dialog component but we're not using the types from it.
For example if I want to use the backdrop props on the modal component, typescript gives us an error.
https://ariakit.org/examples/dialog-backdrop-scrollable#rendering-a-custom-backdrop

[Tech] Implementation

No response

Due Date

No response
@alissiagelabert
Copy link

Once this ticket is solved decomment following tests:

  • test_cypress/cypress/e2e/showcase/critical/Showcase - cover - picture - fullscreen.feature
  • test_cypress/cypress/e2e/showcase/low/Showcase - preview link - close click outside.feature
  • test_cypress/cypress/e2e/showcase/medium/Showcase - block video - play close.feature

@jeromeraffin jeromeraffin changed the title [Modal] Extend modal types with ariakit dialog types [Modal] modal types doesn't use ariakit dialog types Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
existing-component tech
Projects
[WUI] Project Board
Status: To Dev
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeromeraffin @theo-mesnil @alissiagelabert