Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default return from OK #2

Open
mahajanrevant opened this issue Feb 3, 2021 · 1 comment · May be fixed by #5
Open

Change default return from OK #2

mahajanrevant opened this issue Feb 3, 2021 · 1 comment · May be fixed by #5
Assignees
@mahajanrevant
Labels
enhancement New feature or request

Comments

@mahajanrevant
Copy link
Contributor

For even wrong input (format or values), Ok is returned. We should change this behavior appropriately based on what Andrew has implemented for the real robot
@mahajanrevant mahajanrevant added the enhancement New feature or request label Feb 3, 2021
@mahajanrevant mahajanrevant self-assigned this Feb 6, 2021
@mahajanrevant
Copy link
Contributor Author

Will modify Ros2Sim to follow the same protocols that Andrew has implemented for Arduino

@mahajanrevant mahajanrevant linked a pull request Mar 1, 2021 that will close this issue
Implementing comm protocols #5
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahajanrevant mahajanrevant

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implementing comm protocols WPI-MMR/ros2sim
1 participant
@mahajanrevant