Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partials/widget-content.php will never display the byline date #1855

Open
benlk opened this issue Mar 25, 2020 · 1 comment · Fixed by INN/umbrella-mstoday#73
Open

partials/widget-content.php will never display the byline date #1855

benlk opened this issue Mar 25, 2020 · 1 comment · Fixed by INN/umbrella-mstoday#73

Comments

@benlk
Copy link
Collaborator

benlk commented Mar 25, 2020

https://github.com/INN/largo/blob/13e1777b1f39484698d5744a8f0f432be1ee098c/partials/widget-content.php#L45

if the variable is set to false, then because ! empty( false ) === false, the fallback option of true is used.

This can be fixed by switching to isset( ... ) ? ... : ... ;, and making sure that where we use partials/widget-content.php, like in the Largo Recent Posts widget, we do so passing false explicitly.

This is the bug in INN/umbrella-voiceofoc#36.

@benlk
Copy link
Collaborator Author

benlk commented Mar 25, 2020

The default behavior of the widget is to only save the positive, checked value, to assertively hide the date, so rather than testing for the absence of the negative value, should we not instead test for the presence of the positive value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant