Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt]: Create cassettes for external API calls in pytest #1348

Open
gislawill opened this issue Sep 24, 2024 · 2 comments
Open

[Tech Debt]: Create cassettes for external API calls in pytest #1348

gislawill opened this issue Sep 24, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request triage to be triaged for next action

Comments

@gislawill
Copy link
Collaborator

gislawill commented Sep 24, 2024

Provide a clear and concise description of what you want to happen.

PR #1328 adds pytest-recordings to our API tests which stores external API responses within "cassettes" in the codebase. These cassettes can then be used by other developers and in CI to create a more stable test environment (with the added benefits of not needing to share API keys).

We should apply these cassettes to more services as soon as PR #1328 is merged.

Is there anything else you can add about the proposal? You might want to link to related issues here, if you haven't already.

This is relevant to the problem we're in addressing in #1346

@gislawill gislawill added enhancement New feature or request triage to be triaged for next action labels Sep 24, 2024
@gislawill gislawill self-assigned this Sep 24, 2024
@gislawill
Copy link
Collaborator Author

Heads up @wadhwamatic and @ericboucher, I've created this ticket to address after the Google Floods work is merged. Please let me know if you have any thoughts

@wadhwamatic
Copy link
Member

I don't really know what this means tbh so leave it to @ericboucher to give his feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage to be triaged for next action
Projects
None yet
Development

No branches or pull requests

2 participants