Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIU Settings Oculus Android checkbox cannot be checked #246

Open
chengnay opened this issue Mar 20, 2023 · 4 comments
Open

VIU Settings Oculus Android checkbox cannot be checked #246

chengnay opened this issue Mar 20, 2023 · 4 comments

Comments

@chengnay
Copy link
Collaborator

I found out that VIU Settings Oculus Android checkbox cannot be checked when using Oculus Integration v47.
After changing OCULUS_XR_LOADER_NAME to OCULUS_XR_LOADER_CLASS_NAME can fix the issue.

Modify ViveInputUtility\Scripts\Editor\VRPlatformSettings\OculusGoSettings.cs line 529,
if (!XRPluginManagementUtils.IsXRLoaderEnabled(OculusVRModule.OCULUS_XR_LOADER_CLASS_NAME, requirdPlatform)) { return false; }

@tenebris93
Copy link

tenebris93 commented May 10, 2023

Seems the same issue applies with Oculus Desktop when using Oculus Integration v51. If you change OCULUS_XR_LOADER_NAME to OCULUS_XR_LOADER_CLASS_NAME in OculusSettings.cs on line 147. It seems to have fixed the issue.
File Location: ViveInputUtility\Scripts\Editor\VRPlatformSettings\OculusSettings.cs
Picture with fix implemented:
image

Thanks @chengnay your solution work for Android so I thought I would apply the same logic to the Windows side.

Edit: not sure if this fix is also necessary on line 482 of OculusVrModule.cs.
File Location: VRModule\Modules\OculusVRModule.cs
Picture with fix implemented:
image

Edit 2: Looks like on the Windows side it thinks I don't have the latest version of Oculus Integration even with this fix.
image

@chengnay
Copy link
Collaborator Author

Hi @tenebris93,
Could you try updating your VIU to v1.18.1 to see if those issues above are fixed?
Thanks!

@tenebris93
Copy link

Hi @chengnay,
It looks like this fix isn't included in the v1.18.1 update. I still had to manually change all references of OCULUS_XR_LOADER_NAME to OCULUS_XR_LOADER_CLASS_NAME in order for the checkbox to show as clicked.

@chengnay
Copy link
Collaborator Author

Hi @tenebris93,
I will double check again internally.
Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants