Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player#stopSound(name) didn't works for 1.12.2 client #571

Open
4 tasks done
minhh2792 opened this issue Aug 4, 2023 · 2 comments
Open
4 tasks done

player#stopSound(name) didn't works for 1.12.2 client #571

minhh2792 opened this issue Aug 4, 2023 · 2 comments
Labels
legacy 1.9-1.12 Bug, low priority/unsupported

Comments

@minhh2792
Copy link

minhh2792 commented Aug 4, 2023

'/viaversion dump' Output

https://dump.viaversion.com/292dd8fdb6e2939975a7b7cae59e854b0fe10e9ddbb291eee4700d58f5e3fa47

Console Error

none

Bug Description

When using player.stopSound(String soundName, SoundCategory category), on 1.12.2 client (340) and lower, every sound of that channel will be stopped instead of only that specified sound name

Steps to Reproduce

public static void stopMusic(Player player, String name) {
	var ver = getVersion(player); // 340 is 1.12.2
	if (ver > 340) {
		player.stopSound(name, SoundCategory.RECORDS);
	} else {
		player.stopSound(name);
	}
}

There are 2 sounds played, one at the countdown, and one after the countdown ends and the game starts.
Actual behavior: On 1.12.2 client, both two sounds were stopped, instead of one

https://cdn.discordapp.com/attachments/1102133845341507594/1137087084075700315/2023-08-05_01-03-54.mp4

Expected Behavior

The first sound (at the countdown) will be stopped when the game starts, then another sound starts playing as normal

https://cdn.discordapp.com/attachments/1102133845341507594/1137087094284632254/2023-08-05_01-02-15.mp4

Additional Server Info

Plugins:
image

image

Checklist

  • Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. BungeeCord), not on both.
  • I have included a ViaVersion dump.
  • If applicable, I have included a paste (not a screenshot) of the error.
  • I have tried a build from https://ci.viaversion.com/ and the issue still persists.
@Barvalg
Copy link
Member

Barvalg commented Aug 4, 2023

Platform: git--MineVN--%22b548092%22%20%28MC%3A%201.19.4%29
ViaVersion (4.7.0): 20 commits behind master
ViaBackwards(4.7.0): 10 commits behind master
ViaRewind(2.0.3): 17 commits behind master

Please try the latest build(s) from https://ci.viaversion.com/. In case the issue still persists send the new dump

@minhh2792
Copy link
Author

minhh2792 commented Aug 4, 2023

Tried the latest build, the issue still persists

New dump updated

@kennytv kennytv added legacy 1.9-1.12 Bug, low priority/unsupported and removed unconfirmed labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy 1.9-1.12 Bug, low priority/unsupported
Projects
None yet
Development

No branches or pull requests

3 participants