Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add . as a valid option to create or allow no argument #969

Open
a-wallen opened this issue Feb 25, 2024 · 3 comments
Open

feat: add . as a valid option to create or allow no argument #969

a-wallen opened this issue Feb 25, 2024 · 3 comments
Assignees
Labels
feature A new feature or request p2 Important issues not at the top of the work list

Comments

@a-wallen
Copy link

Description
As a user of the very_good_cli I want to be able to use . as the argument for very_good create.

If no argument or . is given, the cli uses the current folder's name as the project name.

@a-wallen a-wallen added the bug Something isn't working as expected label Feb 25, 2024
@alestiago alestiago added the needs triage Issue requires triage label Feb 26, 2024
@tomarra
Copy link
Contributor

tomarra commented Mar 12, 2024

Notes

  • The flutter create command works the same way, allowing . to automatically pull in the current directory name
  • This should not override the current default which is to error out to the help output. If a user wants to use this option they should be explicitly adding . to the command.
  • We do have support for this in the dart_frog_cli already as well

@tomarra tomarra added p2 Important issues not at the top of the work list and removed needs triage Issue requires triage labels Mar 12, 2024
@tomarra
Copy link
Contributor

tomarra commented Mar 12, 2024

Hi @a-wallen 👋 given the notes we have added here would you be willing to help out and submit a PR for this change?

@alestiago alestiago added the waiting for response Waiting for follow up label Mar 15, 2024
@a-wallen
Copy link
Author

yeah I'm down

@alestiago alestiago removed the waiting for response Waiting for follow up label Mar 19, 2024
@alestiago alestiago added feature A new feature or request and removed bug Something isn't working as expected labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or request p2 Important issues not at the top of the work list
Projects
Status: Community
Development

No branches or pull requests

3 participants