LoadingQuotes: more customization & custom quotes support #1795
Conversation
There was a problem hiding this comment.
looks pretty good!
can definitely go forward with a merge after addressing a few issues and making sure it still works
also unrelated to your pr, but in hindsight the XOR encryption is a bit cursed... maybe we could instead move the quotes to a separate file quotes.txt (in plain text) and use
import QuoteLines from "~includeFile/quotes.txt"perhaps you'd like to do that in your pr as well, and maybe we could then also add some fresh quotes
|
Converting to a draft because I suddenly cannot get my installation of Vencord working. The last commit is untested. |
Accomodate Discord update Removes an NSFW quote (Vencord/plugin-requests#129) Fix: it is possible to get an empty quote when additional quotes are empty Fix typo in patch from the merge in last commit Joke quote when no quotes are enabled
|
Back on. It should be good now. |
|
Can you please outright remove the Vaporeon copypasta quote (see #2474) |
|
Already removed. See the last commit message. |
|
Outright, not commented out, I don't think we need to keep the line if it's never seen. |
Done. The commenting syntax is retained, though, in case people want to leave comments there. |
|
thank you! |
|
the patches were kinda bad for the following reasons, thus I changed them:
but the rest is good now so I'll go ahead and merge this, thank you for your work!! |
Vendicated
changed the title
…#1795) Co-authored-by: lewisakura <[email protected]> Co-authored-by: Vendicated <[email protected]>
…#1795) Co-authored-by: lewisakura <[email protected]> Co-authored-by: Vendicated <[email protected]>
Resolve #1654. Resolve Vencord/plugin-requests#185.
Fix quotes not replaced during Halloween.