Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reaper 1080p installation bug #26

Open
HESOYAM-abuser opened this issue Nov 13, 2024 · 4 comments
Open

Reaper 1080p installation bug #26

HESOYAM-abuser opened this issue Nov 13, 2024 · 4 comments

Comments

@HESOYAM-abuser
Copy link

Hi,
When installing Reaper 1080p, It doesn't edit the GRUB configuration file correctly to set the path for theme.txt.

@VandalByte
Copy link
Owner

Hey @HESOYAM-abuser
Can you explain the issue a bit more, like what is happening and where it's happening

@HESOYAM-abuser
Copy link
Author

Hi @VandalByte,

During the installation of Reaper 1080, the process modifies /etc/default/grub, but it doesn't correctly set the value of the GRUB_THEME variable. This variable should point to the path of the theme.txt file. Unfortunately, the installation script fails to configure it properly, so I had to manually update the file myself.

@HESOYAM-abuser
Copy link
Author

I think i found the problem

def install():
    # installer script
    print("\n   INSTALLER ✔️")
    THEME = "dedsec"

    # debian | arch
    if os.path.exists("/boot/grub/"):
        GRUB_THEMES_DIR = "/boot/grub/themes/"
        GRUB_UPDATE_CMD = "grub-mkconfig -o /boot/grub/grub.cfg"

        if not os.path.exists(GRUB_THEMES_DIR):
            os.mkdir(GRUB_THEMES_DIR)

    # fedora | redhat
    elif os.path.exists("/boot/grub2/"):
        GRUB_THEMES_DIR = "/boot/grub2/themes/"
        GRUB_UPDATE_CMD = "grub2-mkconfig -o /boot/grub2/grub.cfg"

        if not os.path.exists(GRUB_THEMES_DIR):
            os.mkdir(GRUB_THEMES_DIR)

    else:
        print(f"\n{R}(!){C} Couldn't find the GRUB directory. Exiting the script ...")
        exit()

    THEME_DIR = f"{GRUB_THEMES_DIR}/{THEME}"

You shoud edit this section accordingly

This code will set the value like this GRUB_THEME="/boot/grub/themes//dedsectheme.txt" but it shoud be like this GRUB_THEME="/boot/grub/themes/dedsec/theme.txt"

@VandalByte
Copy link
Owner

Hey @HESOYAM-abuser 
So I'm guessing you installed the theme via Pling or Gnome looks. I had actually fixed the issue in the git repository a while back, but for making changes to those website packages, I would have to repackage all the files again and upload. I didn't have the time to do so at that time, so I left it the same and urged the users to do a manual install or from git if they find some issue. I will update those when I get some time to kill. Thanks, appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants