Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for browser-sync 3 #97

Open
jkevingutierrez opened this issue Jan 5, 2024 · 10 comments · May be fixed by #96
Open

Add support for browser-sync 3 #97

jkevingutierrez opened this issue Jan 5, 2024 · 10 comments · May be fixed by #96

Comments

@jkevingutierrez
Copy link

browser-sync-webpack-plugin requires browsery-sync^2 as peer-dependency https://github.com/Va1/browser-sync-webpack-plugin/blob/master/package.json#L23

Now that browser-sync 3 was released, it generates a dependency conflict when both packages are used

image
@nlenkowski
Copy link

nlenkowski commented Jan 8, 2024

Just ran into this dependency conflict as well, when upgrading a project to browser-sync@3

@G-Rath G-Rath linked a pull request Jan 15, 2024 that will close this issue
@elrosi
Copy link

elrosi commented Feb 2, 2024

Hi, I have the same problem.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/browser-sync
npm ERR! dev browser-sync@"^3.0.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer browser-sync@"^2" from [email protected]
npm ERR! node_modules/browser-sync-webpack-plugin
npm ERR! dev browser-sync-webpack-plugin@"^2.3.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/browser-sync
npm ERR! peer browser-sync@"^2" from [email protected]
npm ERR! node_modules/browser-sync-webpack-plugin
npm ERR! dev browser-sync-webpack-plugin@"^2.3.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@goxmedia
Copy link

goxmedia commented Feb 3, 2024

Same here:

warning " > [email protected]" has incorrect peer dependency "browser-sync@^2".

@Jas-n
Copy link

Jas-n commented Feb 16, 2024

There's an updated repo on npm via npm install --save-dev browser-sync-v3-webpack-plugin

@AdamReznicek
Copy link

Same here

@caleb-pierce
Copy link

@Jas-n This did not work for me. As soon as I attempted to mix:

watch    
> mix watch

        Additional dependencies must be installed. This will only take a moment.
                                                                                             
        Running: npm install browser-sync-webpack-plugin@^2.3.0 --save-dev --legacy-peer-deps
                                                                                             
        Finished. Please run Mix again.

@Jas-n
Copy link

Jas-n commented Apr 4, 2024

@Jas-n This did not work for me. As soon as I attempted to mix:

watch    
> mix watch

        Additional dependencies must be installed. This will only take a moment.
                                                                                             
        Running: npm install browser-sync-webpack-plugin@^2.3.0 --save-dev --legacy-peer-deps
                                                                                             
        Finished. Please run Mix again.

That's normal for the first run.

Just run the run command again. You won't see it next time 😊.

@brvm
Copy link

brvm commented Apr 19, 2024

@Jas-n when running npm install --save-dev browser-sync-v3-webpack-plugin and then calling .browserSync(), it will still say:

watch    
> mix watch

        Additional dependencies must be installed. This will only take a moment.
                                                                                             
        Running: npm install browser-sync-webpack-plugin@^2.3.0 --save-dev --legacy-peer-deps
                                                                                             
        Finished. Please run Mix again.

Which then proceeds to install the older version and the issue still persists.

@FeBe95
Copy link

FeBe95 commented Apr 26, 2024

I can confirm that the fix mentioned by @Jas-n does not work when using it together with the laravel-mix package. Manual installation of the new package works fine, but laravel-mix always installs the old browser-sync-webpack-plugin automatically again. Unfortunately I didn't find a way to prevent this.

@caleb-pierce
Copy link

caleb-pierce commented Apr 30, 2024

I can confirm that the fix mentioned by @Jas-n does not work when using it together with the laravel-mix package. Manual installation of the new package works fine, but laravel-mix always installs the old browser-sync-webpack-plugin automatically again. Unfortunately I didn't find a way to prevent this.

I am having the same issue. Security vulnerability still persists.

Could we get some other more people to review mozilla/ssl-config-generator#235 and abandon this project switching to a fork that supports v3? I am unsure of the etiquette here as this project hasn't had a release since 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants