Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke which-key from an empty workspace #302

Open
jonaprieto opened this issue Jan 8, 2023 · 7 comments
Open

Invoke which-key from an empty workspace #302

jonaprieto opened this issue Jan 8, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@jonaprieto
Copy link

I'm getting the following behavior:
You open an empty workspace without any editor (file) open.
The keybinding Space Space doesn't open any dialog.
However, if I open a file, it works as expected.

@jonaprieto jonaprieto added the bug Something isn't working label Jan 8, 2023
@MarcoIeni
Copy link
Member

This is a limitation of the extension, unfortunately. This is the expected behavior. :(

@jonaprieto
Copy link
Author

Oh, I see. What if the extension opens a new editor (read-only) like spacemacs initial buffer?

@MarcoIeni MarcoIeni added enhancement New feature or request and removed bug Something isn't working labels Jan 8, 2023
@MarcoIeni MarcoIeni changed the title Keybinding Space Space is unresponsive Invoke which-key from an empty workspace Jan 8, 2023
@MarcoIeni
Copy link
Member

If feasible, sounds good 👍
Maybe this behavior can be opt-in from a configuration option.

@jonaprieto
Copy link
Author

jonaprieto commented Jan 8, 2023

Not sure where to ask things, so let me say it here: It seems VSpaceCode uses under the hood VSCodeVim? If so, is there any reason not to use https://github.com/vscode-neovim/vscode-neovim? The latter seems more robust.

@MarcoIeni
Copy link
Member

Can you open a separate issue for this and explain all the advantages/disadvantages of vscode-neovim vs VSCodeVim?

@stevenguh
Copy link
Member

You open an empty workspace without any editor (file) open.
The keybinding Space Space doesn't open any dialog.

https://github.com/VSpaceCode/VSpaceCode/blob/v0.10.10/src/configuration/keybindings.jsonc#L3-L7
This config should make space key work when no editor is open.

screen.mov

Not sure where to ask things, so let me say it here: It seems VSpaceCode uses under the hood VSCodeVim? If so, is there any reason not to use https://github.com/vscode-neovim/vscode-neovim? The latter seems more robust.

Can you open a separate issue for this and explain all the advantages/disadvantages of vscode-neovim vs VSCodeVim?

#126 is similar to this request.

Neovim doesn't work for vscode web (because it relies on the local neovim installation). The choice of vim is quite personal and it comes with trade off (different kind of performance issues). Overall, I think VSCodeVim is still a pretty good default and work across all environments (e.g. web, local, and remote) of vscode without external binary.

I also understand that there are people that prefer neovim, so I think it is wroth while to explore offering two versions of the extensions (one uses vscode another one uses neovim) or install different vscode vim during the setup process to help people that are using other vim on vscode.

Right now, manually binding override is the only way to use neovim

@MarcoIeni
Copy link
Member

https://github.com/VSpaceCode/VSpaceCode/blob/v0.10.10/src/configuration/keybindings.jsonc#L3-L7
This config should make space key work when no editor is open.

oh, you are right, it works for me too! I din't realize that 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants