Fix nested route changes triggering parent guards #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current way we are tracking route changes is through a changing location pathname; unfortunately, this location change is true for both parent and child nested routes, causing both guards to be triggered.
This PR introduces a new route change detection function, which checks the route path and params (instead of just comparing the location pathname)
Related issues
Fixes #59
What this does
hasPathChanged
->hasRouteChanged
, updates detection to checkmatch.*
instead oflocation.*
null
render for when route has changed but without guards5.3.0
to take advantage of theuseRouteMatch
hook helperHow to test