Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UV controls scale improperly for audio manifests without ranges #944

Open
1 of 3 tasks
benwbrum opened this issue Oct 24, 2023 · 2 comments · May be fixed by #982
Open
1 of 3 tasks

UV controls scale improperly for audio manifests without ranges #944

benwbrum opened this issue Oct 24, 2023 · 2 comments · May be fixed by #982

Comments

@benwbrum
Copy link
Contributor

UV version: 4.0.22

I'm submitting a:

  • bug report => please fork one of these codesandbox examples with a repro of your issue and include a link to it below
  • feature request => please use the user stories repo
  • support request => Please do not submit support requests here, use stackoverflow

Current behavior:
When playing a single audio file, users generally want the UV control to be smallish--120-200 pixels high--since there is no video to display and no navigation needed. When loading a IIIF manifest without ranges containing only audio content, the player controls (play, next, volume, etc) scale down to the height of the div, making them appear to be tiny.

Example:
Screenshot from 2023-10-24 09-12-09

Expected behavior:
The controls should not scale down, but rather appear at the full width of the player.

Steps to reproduce:

Load this manifest in a div sized at 180px: https://saracarl.github.io/comparison-test/her-kind/manifest.json

Related code:
According to discussion on UV Slack, this is caused by some special handling for range-less audio content:

Unfortunately, this work-around only works for manifests that contain ranges, so it is not universal.

@saracarl
Copy link

saracarl commented Nov 8, 2023

So just skipping the media element extension, as in @benwbrum's PR above, introduces CORS issues:

Access to video at 'https://ia601606.us.archive.org/0/items/arrival-beginning/ArrivalBeginning.mp4' from origin 'https://lgsump.github.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

(This is true for media at multiple sites, including Internet Archive which usually is wide open.)

We're not sure why. Any ideas?

@benwbrum
Copy link
Contributor Author

The CORS issue above appears to be irrelevant.

benwbrum added a commit to hipstas/universalviewer that referenced this issue Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants