-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for placeholderCanvas and accompanyingCanvas #731
Comments
Relates to: IIIF-Commons/manifesto#52 |
All issues will be triaged for further investigation or closure by the 28 September 2023. If your issue is still relevant and would like for it be investigated further please comment by 14 September 2023. |
Still relevant, yes.
How UV presents the manifests
For comparison, here are 2 viewers that implement And one of those that implements |
UV version:
I'm submitting a:
Current behavior:
Currently when viewing a manifest with a placeholderCanvas or a accompanyingCanvas the UV ignores these properties and shows the main content.
Expected behavior:
For the
placeholderCanvas
example it should show the placeholder image while the video is loading.For the
accompanyingCanvas
it should play the music while the images are shown.Steps to reproduce:
placeholderCanvas
: https://uv.netlify.app/#?c=&m=&s=&cv=&manifest=https%3A%2F%2Fpreview.iiif.io%2Fcookbook%2F0013-placeholderCanvas%2Frecipe%2F0013-placeholderCanvas%2Fmanifest.jsonaccompanyingCanvas
: https://uv.netlify.app/#?c=&m=&s=&cv=&manifest=https%3A%2F%2Fpreview.iiif.io%2Fcookbook%2F0014-accompanyingCanvas%2Frecipe%2F0014-accompanyingcanvas%2Fmanifest.json&xywh=-2467%2C-268%2C8429%2C5358Related code:
Looks to be related to here:
universalviewer/src/lib/manifold.js
Line 764 in 2a08b8a
Other information:
This is part of the IIIF Cookbook work and relevant recipes are:
The text was updated successfully, but these errors were encountered: