Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show deprecation warnings for getAttribution #634

Closed
edsilv opened this issue Dec 13, 2018 · 2 comments
Closed

Don't show deprecation warnings for getAttribution #634

edsilv opened this issue Dec 13, 2018 · 2 comments

Comments

@edsilv
Copy link
Member

edsilv commented Dec 13, 2018

Fix deprecation warning in UV (don’t call getAttribution anywhere).
In manifesto make getAttribution a proxy of getRequiredStatement and put the attribution fallback logic into getRequiredStatement.

Related: IIIF-Commons/manifesto#37
@tomcrane tomcrane mentioned this issue Dec 13, 2018
Open
@LlGC-szw
Copy link

All issues will be triaged for further investigation or closure by the 28 September 2023. If your issue is still relevant and would like for it be investigated further please comment by 14 September 2023.

@edsilv
Copy link
Member Author

edsilv commented Sep 28, 2023

Closing as inactive

@edsilv edsilv closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edsilv @LlGC-szw