-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Netty #4058
Comments
As I understand, Netty was used to replace the first old (removed now) sockets server, to serve HTTP requests. I tried few year ago to upgrade to Netty v4 without success (it was working, but transcoded stream fails). Did you tried the JavaHttpServer ? Or switch to Apache Http Core 5 server ? |
I'll do some testing with JavaHttpServer |
Should I do |
as the default is JUPnP+ add ContentDirectory service inside JUPnP. On V14, it's also create DIDL from brand new classes that handle ContentDirectory V4 things, but I need to finish it (DLNA). The final long term goal could be to use all UPnP things under JUPnP, served by the common JDK HTTPServer, as it use nio now. UPnP things -> JUPnP services. Then we will have only one "engine" to manage with, and things will be well splitted between the upnp services and the media server itself. |
We have a long history of trying to update from Netty v3 to v4.
The last attempt, we tried updating to
4.1.50
and it broke browsing for some renderers as detailed in this issue: #2105So we reverted it in this PR #2107
I had hoped we didn't have to touch this again, but last month there were a lot of vulnerabilities disclosed that affect Netty v3:
https://github.com/UniversalMediaServer/UniversalMediaServer/security/dependabot/24
https://github.com/UniversalMediaServer/UniversalMediaServer/security/dependabot/29
https://github.com/UniversalMediaServer/UniversalMediaServer/security/dependabot/27
https://github.com/UniversalMediaServer/UniversalMediaServer/security/dependabot/30
https://github.com/UniversalMediaServer/UniversalMediaServer/security/dependabot/28
https://github.com/UniversalMediaServer/UniversalMediaServer/security/dependabot/26
https://github.com/UniversalMediaServer/UniversalMediaServer/security/dependabot/25
https://github.com/UniversalMediaServer/UniversalMediaServer/security/dependabot/23
The text was updated successfully, but these errors were encountered: