feat(theming): add icon to Windows executable #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the code health analysis summary for commits Analysis Summary
|
|
Thanks for this! Related opinion: #197 (comment) Since you're on Windows, could you post comparison sizes for both the debug & release builds? |
AnonymousWP
changed the title
|
@adhirajsinghchauhan The screenshot was from a VM. The executables were built using Not sure about |
nozwock
force-pushed
the
win-executable-icon
branch
from
fd50320
to
9cc1799
Compare
|
Something to note is that the icon size would be about 130KB instead of 400KB, if we were to reduce the max icon size from 256px to 128px. If you're concerned about size that is. Also, here are the file sizes with
|
adhirajsinghchauhan
approved these changes
May 21, 2024
adhirajsinghchauhan
merged commit 59a6605
into
Universal-Debloater-Alliance:main
9 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #462
embed-resource.The icon is just the
logo-dark.pngwith a dark background and slightly curved borders. We should go with it unless we have a better design.