Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make neos/swiftmailer optional? #18

Open
rolandschuetz opened this issue Jun 29, 2021 · 2 comments
Open

Make neos/swiftmailer optional? #18

rolandschuetz opened this issue Jun 29, 2021 · 2 comments

Comments

@rolandschuetz
Copy link
Contributor

I think SwiftMailer could be an optional dependency, only needed when you use the main feature. What do you think?
@markusguenther
Copy link
Member

Could make sense, but then I need to create another package that takes care of that.
Do you have issues with the mailer that is included or is it more to save dependencies?

@rolandschuetz
Copy link
Contributor Author

rolandschuetz commented Jun 29, 2021 •
edited
Loading

No, not abort, I would just check here is the class exists, and it not throws an exception that the user needs to consider the optional dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rolandschuetz @markusguenther