-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to WP Plugin #7
Milestone
Comments
Somewhat made this better by saving the webhook from freemius and later processing it. This might still be better as a plugin and make it easier to build on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now Freemius limits the webhooks execution to 10 seconds. This is not ideal since the Mautic API can take a while to process the logic it needs to.
I can foresee that as a mautic install grows, it would take more time to run the processes Coach Freem is asking it to. One such process is to search for a contact when only given the email: https://github.com/UVLabs/coach-freem/blob/1.1.3/includes/Contacts/Base.php#L60
It would be best to save the webhook received by Freemius for later processing instead of trying to run all the logic while the webhook is limited to 10 seconds.
Converting Coach to a plugin will also make it easier to get started with for other Freemius users not big on editing code.
The text was updated successfully, but these errors were encountered: