Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Type Annotations to emanifest Python Package #1614

Closed
3 of 5 tasks
dpgraham4401 opened this issue Jul 12, 2024 · 1 comment
Closed
3 of 5 tasks

Add Type Annotations to emanifest Python Package #1614

dpgraham4401 opened this issue Jul 12, 2024 · 1 comment
Assignees
Labels
python Pull requests that update Python code

Comments

@dpgraham4401
Copy link
Member

dpgraham4401 commented Jul 12, 2024

Python 3.7 has reached end of life, which is our current pyproject.toml required python version. Python 3.8 and 3.10 introduced some useful features around type annotations, such as TypedDicts that would be useful for our library users, especially with service calls that make user of extensive **kwargs like the updated search service in #1610.

A PR that resolves this will update the minimum supported version of python in the following places.

  • configs
  • CI/CD
  • Docs
  • Set up the necessary dependencies and configs to make use of type annotations for our library's API,
  • Annotate **kwarg heavy APIs with TypeDicts
@dpgraham4401 dpgraham4401 added the python Pull requests that update Python code label Jul 12, 2024
@dpgraham4401
Copy link
Member Author

Configs, CI/CD and docs where updated in #1615

@dpgraham4401 dpgraham4401 self-assigned this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

1 participant