Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to monorepo packages are not updated after the initial launch #793

Open
ferm10n opened this issue Jan 16, 2023 · 4 comments
Open
Labels

Comments

@ferm10n
Copy link

ferm10n commented Jan 16, 2023

Current behavior

Changes to ts or d.ts files are not detected after launching webpack dev server (regression of #557)

Expected behavior

Changes to types should be updated dynamically across package boundaries in a monorepo.

Steps to reproduce the issue

  • open either of the environments mentioned below
  • in examples/ts-loader-monorepo do yarn dev
  • make changes to examples/ts-loader-monorepo/packages/util/src/index.ts, changing ProbablyANumber to number or string
  • notice how problem is not detected until restarting dev server

Issue reproduction repository

live in browser env: https://stackblitz.com/edit/ferm10n-fork-ts-checker-webpack-plugin-dftrye?file=examples%2Fts-loader-monorepo%2Fpackages%2Fmain%2Fsrc%2Findex.ts

Or, for cloning locally: https://github.com/ferm10n/fork-ts-checker-webpack-plugin

(It's reproducible in both environments)

Environment

  • fork-ts-checker-webpack-plugin: 7.3.0
  • typescript: 4.9.4
  • eslint: n/a ?
  • webpack: 5.75.0
  • os: Both Windows 10 and Ubuntu 18.04
@ferm10n ferm10n added the bug label Jan 16, 2023
@ferm10n
Copy link
Author

ferm10n commented Jan 16, 2023

Just tried testing the reproduction from the original issue. It works with 7.3.0 (the version this one tested against), so that tells me this is not a regression, but a new issue I guess?

@ferm10n ferm10n changed the title Regression: Type changes to symlinked module files in a monorepo are not updated after the initial launch Changes to monorepo packages are not updated after the initial launch Jan 16, 2023
@ferm10n
Copy link
Author

ferm10n commented Jan 16, 2023

Also, I saw some similar issues here mention https://github.com/pigcan/extra-watch-webpack-plugin. I'm able to use this as a workaround.

@bnussman-akamai
Copy link

Having the same issue with types in monorepo changing but the fork-ts-checker-webpack-plugin is not picking up the change.

@xiaosen7
Copy link

Same problom, does any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants