Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO items #18

Open
YousefED opened this issue Mar 9, 2022 · 1 comment · May be fixed by #729
Open

TODO items #18

YousefED opened this issue Mar 9, 2022 · 1 comment · May be fixed by #729
Labels
enhancement New feature or request prio:mid Medium priority

Comments

@YousefED
Copy link
Collaborator

YousefED commented Mar 9, 2022

Add support for TODO items:

  • TODO items should show a checkbox on the side
  • The checked state should be stored in the prosemirror state
  • If possible, content of checked todo items should appear strikethrough (I think we can do this directly from CSS)
  • show "To-do" as placeholder

We currently store a listType attribute on Blocks. On first thought, we could:
a. use listType="todo-checked" and listType="todo-unchecked"
b. use listType="todo" and todo-checked="true" as attributes

Option B seems cleaner, but option A has other benefits (we don't need to clean for "invalid" Prosemirror states, for example, what does listType="li" and todo-checked mean? In that case todo-checked should be removed. What do you think is the best architecture for this?

@YousefED YousefED added the enhancement New feature or request label May 30, 2023
@matthewlipski matthewlipski added the prio:low Low priority label Jul 6, 2023
@matthewlipski matthewlipski added prio:mid Medium priority and removed prio:low Low priority labels Sep 27, 2023
@frogman544
Copy link

Any ETA for this?

@matthewlipski matthewlipski linked a pull request May 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio:mid Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants